IBrowserFile.ContentType fix #25702
Merged
IBrowserFile.ContentType fix #25702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackinnonBuck
requested review from
a team and
SteveSandersonMS
as code owners
ghost
added
the
pranavkm
approved these changes
Sep 8, 2020
javiercn
approved these changes
Sep 8, 2020
SteveSandersonMS
approved these changes
Sep 8, 2020
mkArtakMSFT
added
Servicing-approved
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
Contributor
|
@Pilchie can we get this in for RC2? |
…into t-mabuc/input-file-content-type-fix
Pilchie
added
Servicing-approved
Member
|
Approved for .NET 5 RC2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
IBrowserFile.ContentTypefield was not being correctly populated by the JS implementation for theInputFilecomponent. This was caused by a change from theInputFileAPI review, which was applied in the C# implementation but not the JS implementation. This PR fixes that issue and adds tests verifying that all fields inIBrowserFileare correctly populated.Customer Impact
Customers will now be able to use the
IBrowserFile.ContentTypefield.Regression?
No.
Risk
Virtually no risk. This PR is a simple variable rename with updated tests and test components.
Addresses #25679