Fix wasm caching on localhost and various E2E test issues #25689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveSandersonMS
added
area-blazor
SteveSandersonMS
force-pushed
the
stevesa/fix-wasm-caching
branch
from
7c07278 to
755949b
Compare
javiercn
approved these changes
Sep 8, 2020
SteveSandersonMS
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
Member
Author
|
@Pilchie Can this be approved for RC2? I'm aware of the build failure - it's happening for all PRs. |
Member
Author
|
@javiercn I've repurposed this PR to include, in addition to what was there before, various other test fixes. You may want to re-review as there's quite a bit more here now :) |
SteveSandersonMS
changed the title
Member
|
@SteveSandersonMS re-reviewed. |
Pilchie
added
Servicing-approved
Member
|
Approved for .NET 5 RC2. |
Member
Author
|
@mkArtakMSFT Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #24012 we introduced a regression whereby
localhost/127.0.0.1was excluded from Blazor WebAssembly caching. The result is that the behavior is different when running locally compared with in production, which risks hard-to-detect bugs.This is particularly frustrating because our E2E tests actually tell us that there's a defect here, but the relevant ones are marked as quarantined.
Update
I've also added fixes for various E2E test issues I found while investigating the above (and E2E tests generally). As of this PR, all the E2E tests pass locally for me, at least after working around various unrelated build issues.