Skip to content

Add public API baselines for Servers #25652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2020
Merged

Add public API baselines for Servers #25652

merged 1 commit into from
Sep 10, 2020

Conversation

@Pilchie
Copy link
Member

@Pilchie Pilchie commented Sep 6, 2020

No description provided.

@Pilchie Pilchie added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-servers labels Sep 6, 2020
@Pilchie Pilchie added this to the 5.0.0-rc2 milestone Sep 6, 2020
@Pilchie Pilchie requested a review from dougbu September 6, 2020 00:01
@Pilchie Pilchie added the tell-mode Indicates a PR which is being merged during tell-mode label Sep 6, 2020
@Pilchie
Copy link
Member Author

Pilchie commented Sep 6, 2020

Part of #24347

@dougbu dougbu mentioned this pull request Sep 6, 2020
Closed
@dougbu
Copy link
Contributor

dougbu commented Sep 6, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 6, 2020

Azure Pipelines successfully started running 2 pipeline(s).

@Pilchie
Copy link
Member Author

Pilchie commented Sep 9, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 9, 2020

Azure Pipelines successfully started running 2 pipeline(s).

@ghost
Copy link

ghost commented Sep 10, 2020

Hello @Pilchie!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Sep 10, 2020

Apologies, while this PR appears ready to be merged, it looks like release/5.0-rc2 is a protected branch and I have not been granted permission to perform the merge.

@hoyosjs hoyosjs mentioned this pull request Sep 10, 2020
Merged
@Pilchie Pilchie merged commit 6828192 into dotnet:release/5.0-rc2 Sep 10, 2020
@Pilchie Pilchie deleted the api-baselines-servers branch September 10, 2020 04:08
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

+1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

5.0.0-rc2

Development

Successfully merging this pull request may close these issues.

4 participants

@Pilchie @dougbu @halter73 @amcasey