Skip to content

Conversation

@mkArtakMSFT
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT commented Sep 4, 2020

Description

For the PlatformCompaotibilityAnalyzer to highlight issues it needs to know the target platform.
We've made a change to include that in the Blazor WebAssembly Shared project, but missed this one.

Customer Impact

Customers won't be flagged by the analyzer without this setting.

Regression

No

Risk

Low

Addresses #25337

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Sep 4, 2020
@mkArtakMSFT mkArtakMSFT requested a review from a team September 4, 2020 23:24
@mkArtakMSFT mkArtakMSFT added the Servicing-consider Shiproom approval is required for the issue label Sep 4, 2020
@ghost
Copy link

ghost commented Sep 4, 2020

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

@mkArtakMSFT mkArtakMSFT added this to the 5.0.0-rc2 milestone Sep 4, 2020
@tebeco
Copy link
Contributor

tebeco commented Sep 4, 2020

wrong link to issue / pull request for th the addresses #xxxx I think

@mkArtakMSFT
Copy link
Contributor Author

wrong link to issue / pull request for th the addresses #xxxx I think

Thanks, fixed it.

@Pilchie Pilchie added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Sep 4, 2020
@Pilchie
Copy link
Member

Pilchie commented Sep 4, 2020

Approved for .NET 5.0 RC2 pending CI completion and PR signoff.

@mkArtakMSFT mkArtakMSFT merged commit 0d548f3 into release/5.0-rc2 Sep 9, 2020
@mkArtakMSFT mkArtakMSFT deleted the mkArtakMSFT-patch-4 branch September 9, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants