Skip to content

Conversation

@Pilchie
Copy link
Member

@Pilchie Pilchie commented Sep 3, 2020

No description provided.

@Pilchie Pilchie requested a review from dougbu September 3, 2020 21:25
@Pilchie Pilchie added this to the 5.0.0-rc2 milestone Sep 3, 2020
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 3, 2020
@dougbu
Copy link
Contributor

dougbu commented Sep 3, 2020

Need to run a quick errand but I'll approve this when I get back…

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side question: Have you hit any projects needing $(MSBuildProjectDirectory)\$(_TFMDirectory)\PublicAPI.Shipped.txt files❔ I know we have a few #if blocks that change the public API but haven't hit that case yet. Then again, I haven't built my lower-level baseline addition branch yet…

@Pilchie
Copy link
Member Author

Pilchie commented Sep 4, 2020

Personally I haven't needed TFM specific public API yet.

@Pilchie Pilchie merged commit 844bcb5 into dotnet:release/5.0-rc2 Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants