Skip to content

Declare AddScheme's displayName parameter as nullable #25480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2020
Merged

Declare AddScheme's displayName parameter as nullable #25480

merged 1 commit into from
Sep 1, 2020

Conversation

@kevinchalet
Copy link
Contributor

@kevinchalet kevinchalet commented Sep 1, 2020

Fixes #25422.

@ghost ghost added the area-servers label Sep 1, 2020
@kevinchalet kevinchalet changed the base branch from master to release/5.0 September 1, 2020 00:43
@kevinchalet kevinchalet force-pushed the authentication_options_annotations branch from ec43a9b to 36f2023 Compare September 1, 2020 00:43
@kevinchalet kevinchalet marked this pull request as ready for review September 1, 2020 14:45
@Tratcher Tratcher requested a review from pranavkm September 1, 2020 14:46
@kevinchalet kevinchalet mentioned this pull request Sep 1, 2020
Closed
@pranavkm pranavkm added this to the 5.0.0-rc1 milestone Sep 1, 2020
@pranavkm
Copy link
Contributor

pranavkm commented Sep 1, 2020

@Pilchie could we approve this for rc1?

@Pilchie Pilchie added the Servicing-approved Shiproom has approved the issue label Sep 1, 2020
@Pilchie
Copy link
Member

Pilchie commented Sep 1, 2020

Approved for RC1

@Pilchie Pilchie merged commit 29042be into dotnet:release/5.0 Sep 1, 2020
@kevinchalet kevinchalet deleted the authentication_options_annotations branch September 1, 2020 16:23
@kevinchalet
Copy link
Contributor Author

kevinchalet commented Sep 1, 2020

Thanks 😸

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher Tratcher is a code owner

1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue

Projects

None yet

Milestone

5.0.0-rc1

Development

Successfully merging this pull request may close these issues.

AuthenticationOptions.AddScheme() should declare displayName as nullable

4 participants

@kevinchalet @pranavkm @Pilchie @amcasey