Use $(TargetFrameworkIdentifier) and $(TargetFrameworkVersion) consistently
#25428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsistently - always use `$([MSBuild]::VersionXYZ(...))` for version checks - use `$(NETCoreAppFrameworkIdentifier)` where it's available - move `$(KnownAppHostPackOrFrameworkReferenceTfm)` setting to Directory.Build.props - use it to correct `@(KnownFrameworkReference)` updates - metadata of those items still uses `netcoreapp5.0` - see also dotnet/efcore#22279 (comment) nits: - do not assume `$(TargetFrameworkVersion)` starts with a 'v'; valid w/o it - add `$(_IsMicrosoftNETCoreApp20OrOlder)` property in OpenAPI targets file - evaluate the `Condition` once instead of three times
dougbu
commented
Aug 30, 2020
wtgodbe
approved these changes
Aug 31, 2020
Pilchie
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$([MSBuild]::VersionXYZ(...))for version checks$(NETCoreAppFrameworkIdentifier)where it's available$(KnownAppHostPackOrFrameworkReferenceTfm)setting to Directory.Build.props@(KnownFrameworkReference)updatesnetcoreapp5.0nits:
$(TargetFrameworkVersion)starts with a 'v'; valid w/o it$(_IsMicrosoftNETCoreApp20OrOlder)property in OpenAPI targets fileConditiononce instead of three times