Skip to content

Fix Http/3 and mark multiplexed factory as experimental #25012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 19, 2020
Merged

Fix Http/3 and mark multiplexed factory as experimental #25012

merged 10 commits into from
Aug 19, 2020

Conversation

@jkotalik
Copy link
Contributor

@jkotalik jkotalik commented Aug 18, 2020

Fixes #19313. Also verified that HTTP/3 works with latest changes from runtime.

@ghost ghost added the area-servers label Aug 18, 2020
@jkotalik jkotalik added the tell-mode Indicates a PR which is being merged during tell-mode label Aug 18, 2020
Tratcher
Tratcher approved these changes Aug 18, 2020
View reviewed changes
halter73
halter73 reviewed Aug 18, 2020
View reviewed changes
@jkotalik
Copy link
Contributor Author

jkotalik commented Aug 19, 2020

I'm going to file an issue for obsoleting KestrelServer and avoid doing it in this PR, as we aren't certain ourselves in whether we should obsolete or not.

@davidfowl
Copy link
Member

davidfowl commented Aug 19, 2020

Should we make this pubternal instead?

@jkotalik
Copy link
Contributor Author

jkotalik commented Aug 19, 2020

Should we make this pubternal instead?

That was the original commit, making the connection abstraction APIs in the Experimental namespace without internalizing them.

We generally felt that exposing pubternal APIs was questionable, especially as we have avoided and removed pubternal apis in the past. However, I do think there could be a case for an exception here because these APIs are experimental and we'd encourage people to try them out.

@davidfowl davidfowl linked an issue Aug 19, 2020 that may be closed by this pull request
Using SignalR core with Unity and IL2CPP (AOT) #12102
Open
@jkotalik
Copy link
Contributor Author

jkotalik commented Aug 19, 2020

@davidfowl I don't think this PR will fix the SignalR Core issue, will it?

@jkotalik jkotalik removed a link to an issue Aug 19, 2020
Using SignalR core with Unity and IL2CPP (AOT) #12102
Open
@jkotalik jkotalik merged commit 9f398d9 into release/5.0 Aug 19, 2020
@jkotalik jkotalik deleted the jkotalik/fixHttp3 branch August 19, 2020 21:27
@davidfowl
Copy link
Member

davidfowl commented Aug 19, 2020

Which signalr core issue?

@jkotalik
Copy link
Contributor Author

jkotalik commented Aug 19, 2020

You linked #12102 to be fixed by this PR?

@seriouz
Copy link

seriouz commented Sep 12, 2020

@davidfowl I think he linked the issue #12102 by mistake.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 left review comments

@Tratcher Tratcher Tratcher approved these changes

+1 more reviewer

@pranavkm pranavkm pranavkm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jkotalik @davidfowl @seriouz @halter73 @pranavkm @Tratcher @amcasey