Remove \r\n for \n when writing to ostream #24980
Conversation
ghost
added
the
|
Why? Is there an issue for this? |
|
@BrennanConroy do you remember if there was an issue for this? IIRC there was one filed in the past. We have noticed it multiple times when debugging stdout logs from customers and other things. |
|
I know I complained about it in the past, there may have been an issue at one point from an external customer... |
| const auto multiByte = to_multi_byte_string(text, CP_UTF8); | ||
| auto multiByte = to_multi_byte_string(text, CP_UTF8); | ||
|
|
||
| // Writing \r\n to an ostream will cause two new lines to be written rather |
There was a problem hiding this comment.
Will \n will be written without \r in the final file output?
Also, I don't think ostream was the issue, iirc it was a Windows API we were calling the duplicated the newline
There was a problem hiding this comment.
Hm, when I was testing it, I called ostream << "test\r\n" and I see two new lines in the file.
There was a problem hiding this comment.
Isn't this ostream the fake file that is then redirected? I could be wrong, it has been a long time since I looked at this
There was a problem hiding this comment.
I don't believe so, the m_file points directly to the stdout file.
|
|
||
| Assert.Contains("TEST MESSAGE", contents); | ||
| Assert.DoesNotContain("\r\n\r\n", contents); | ||
| Assert.Contains("\r\n", contents); |
jkotalik
added
the
tell-mode
amcasey
added
area-networking
When writing to the stdout file with ANCM, for some reason, \r\n get interpreted as two new lines when writing to an ostream. This change replaces \r\n with \n before writing to the file.