Optimize writing single segment sequences #24929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
What kinda gains are you seeing? |
Member
Author
|
I didn't microbenchmark. It showed up in benchmark and seems like a simple thing to improve.
|
davidfowl
reviewed
Aug 15, 2020
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public static void CopyTo(in this ReadOnlySequence<byte> buffer, PipeWriter pipeWriter) |
Member
There was a problem hiding this comment.
Maybe we should add this to ReadOnlySequence the target would be an IBufferWriter
Member
Author
There was a problem hiding this comment.
Add it to runtime? Could do. It has this today:
public static class BuffersExtensions
{
public static void Write<T>(this IBufferWriter<T> writer, ReadOnlySpan<T> value)
{
}
}
Tratcher
approved these changes
Aug 17, 2020
Member
|
Put this in the RC1 branch |
JamesNK
added
the
tell-mode
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid foreach over
ReadOnlySequence<byte>when it is a single segment.