Include the DebugProxy binaries in DevServer #24817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unused nuspec property that relied on relative path
ghost
added
the
captainsafia
approved these changes
Aug 11, 2020
Member
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
Looks good! I validated the changes in this branch on an in-browser debugging end-to-end with Blazor WASM and it works.
pranavkm
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
pranavkm
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DebugProxy binaries required to enable debugging for Blazor WebAssembly applications are missing from our packages. This was caught as part of local testing
Customer impact
This prevents debugging Blazor WebAssembly applications
Regression
Yes. This was functioning in preview7 and was regressed due to some infrastructure changes.
Risk
Low. This is a primarily a change to the packaging to include the missing files.