Skip to content

Reset KeepAliveTimeout on HTTP/2 ping #24644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2020
Merged

Reset KeepAliveTimeout on HTTP/2 ping #24644

merged 2 commits into from
Aug 11, 2020

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 7, 2020

Fixes #24601

@ghost ghost added the area-servers label Aug 7, 2020
@JamesNK JamesNK requested a review from davidfowl August 7, 2020 20:30
@JamesNK JamesNK added this to the 5.0.0-rc1 milestone Aug 7, 2020
@JamesNK JamesNK merged commit 5fbd1eb into master Aug 11, 2020
@JamesNK JamesNK deleted the jamesnk/http2-ping-keepalive branch August 11, 2020 02:59
JamesNK added a commit that referenced this pull request Aug 13, 2020
@JamesNK
Reset KeepAliveTimeout on HTTP/2 ping (#24644)
03fcfea
@JamesNK JamesNK mentioned this pull request Aug 13, 2020
Merged
wtgodbe pushed a commit that referenced this pull request Aug 13, 2020
@JamesNK
3.1: Reset KeepAliveTimeout on HTTP/2 ping (#24858)
229e496 
* Reset KeepAliveTimeout on HTTP/2 ping (#24644)

* Fix flaky keepalive ping test (#24804)

* Fix flaky keepalive ping test

* Clean up stream

* Remove quarantine attribute

* Fix test
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

5.0.0-rc1

Development

Successfully merging this pull request may close these issues.

Kestrel doesn't reset KeepAlive timeout on HTTP2 PING frames

4 participants

@JamesNK @halter73 @amcasey