Update the templates CSS to leverage CSS isolation #24380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
javiercn
commented
Jul 28, 2020
src/ProjectTemplates/BlazorTemplates.Tests/BlazorServerTemplateTest.cs
Outdated
Show resolved
Hide resolved
javiercn
commented
Jul 28, 2020
src/ProjectTemplates/test/Infrastructure/TemplateTests.props.in
Outdated
Show resolved
Hide resolved
javiercn
commented
Jul 28, 2020
...ectTemplates/Web.ProjectTemplates/content/BlazorServerWeb-CSharp/Shared/MainLayout.razor.css
Outdated
Show resolved
Hide resolved
javiercn
added
the
ask-mode
...mplates/Web.ProjectTemplates/content/ComponentsWebAssembly-CSharp/Client/wwwroot/css/app.css
Show resolved
Hide resolved
SteveSandersonMS
approved these changes
Jul 28, 2020
Member
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
There was a problem hiding this comment.
Looks great! The CSS is so much better this way.
mkArtakMSFT
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
mkArtakMSFT
added
Servicing-approved
Contributor
|
This has been approved by Tactics. @javiercn please let me know when this is ready to be merged and I'll do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22781
Description
This change updates the Blazor templates to use the new CSS isolation support we've built into preview8. The changes are scoped to the template except for a minor change we needed to do to adjust to the fact that we don't have a WebAssembly SDK in preview8.
Customer Impact
It will be very hard for customers to experience the feature first hand without the templates changes. These changes make it trivial for customers to get started using the feature from a new project. This is the most voted feature Blazor is doing for 5.0 (200+ votes on GH) so we want to get feedback on it, and having it on the template makes it much more visible to customers.
Regression?
No
Risk
Low. Changes are focused on the templates, we have end to end automation that validates the updates and we have validated manually that the visual aspect and functionality of the templates has not regressed.