Skip to content

Add a readonly modifier to a missing readonly field #24379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 29, 2020
Merged

Add a readonly modifier to a missing readonly field #24379

merged 8 commits into from
Jul 29, 2020

Conversation

@hueifeng
Copy link
Contributor

@hueifeng hueifeng commented Jul 28, 2020

Add a readonly modifier to a missing readonly field. The readonly modifier ensures the field can only be given a value during its initialization or in its class constructor.

@ghost ghost added the area-servers label Jul 28, 2020
pranavkm
pranavkm approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. @halter73 in case there are some mysterious reasons we wouldn't want to take this PR.

@halter73
Copy link
Member

halter73 commented Jul 29, 2020

LGTM too.

@halter73 halter73 merged commit ae840db into dotnet:master Jul 29, 2020
halter73
halter73 reviewed Jul 29, 2020
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 left review comments

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

+1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hueifeng @halter73 @pranavkm @amcasey