Blazor: add support for ontoggle event #24036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added support of ontoggle event - added test in BasicTestApp
ghost
added
the
|
|
pranavkm
reviewed
Jul 16, 2020
src/Components/test/testassets/BasicTestApp/EventCallbackTest/OnToggleEventTestComponent.razor
Outdated
Show resolved
Hide resolved
Contributor
Yes please. We commit these to source for some hard-to-explain reasons. |
- Regenerated ref assemblies - Formatting - Removing not useful comment - Commited blazor.server.js and blazor.webassembly.js
# Conflicts: # src/Components/Web.JS/dist/Release/blazor.server.js # src/Components/Web.JS/dist/Release/blazor.webassembly.js
Contributor
Author
|
@pranavkm Looks like I fix all your review propositions. |
mkArtakMSFT
added
the
community-contribution
pranavkm
approved these changes
Jul 16, 2020
Contributor
|
Thanks for the PR! |
captainsafia
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
@ontoggleeventFix Issue: #20859
Question: Should I commit also this files? I am not sure because they can be regenerated after build.
\src\Components\Web.JS\dist\Release\blazor.server.js\src\Components\Web.JS\dist\Release\blazor.webassembly.js