Skip to content

Use TryGetValue() in TokenExtensions #23708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2020
Merged

Use TryGetValue() in TokenExtensions #23708

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d87b7f1
Make fields constants
martincostello Jul 6, 2020
6855418
Use TryGetValue()
martincostello Jul 6, 2020
fb82c02
Apply code review suggestion
martincostello Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/Http/Authentication.Abstractions/src/TokenExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ namespace Microsoft.AspNetCore.Authentication
/// </summary>
public static class AuthenticationTokenExtensions
{
private static string TokenNamesKey = ".TokenNames";
private static string TokenKeyPrefix = ".Token.";
private const string TokenNamesKey = ".TokenNames";
private const string TokenKeyPrefix = ".Token.";

/// <summary>
/// Stores a set of authentication tokens, after removing any old tokens.
Expand Down Expand Up @@ -76,9 +76,8 @@ public static void StoreTokens(this AuthenticationProperties properties, IEnumer
}

var tokenKey = TokenKeyPrefix + tokenName;
return properties.Items.ContainsKey(tokenKey)
? properties.Items[tokenKey]
: null;

return properties.Items.TryGetValue(tokenKey, out var value) ? value : null;
}

public static bool UpdateTokenValue(this AuthenticationProperties properties, string tokenName, string tokenValue)
Expand Down