Minor code refactoring to TestHost library #23692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a number of fields that aren't changed readonly.
Use a range to trim the last character of the paths.
Use nameof() for exceptions rather than literals.
Use Task.CompletedTask instead of Task.FromResult().
Use Array.Empty() instead of allocating an empty array.
Remove unused CancellationToken parameter.
ghost
added
the
Fix compilation error.
Tratcher
approved these changes
Jul 6, 2020
Add comment explaining range syntax. Co-authored-by: Chris Ross <[email protected]>
Tratcher
approved these changes
Jul 6, 2020
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies a number of small Visual Studio code refactoring suggestions to the TestHost library code, plus a handful of things I spotted by eye while resolving them.