CSS isolation rewriter tool #23657
Merged
CSS isolation rewriter tool #23657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveSandersonMS
force-pushed
the
stevesa/css-isolation-rewriter-tool
branch
from
b51b6f4 to
6c766e5
Compare
javiercn
approved these changes
Jul 8, 2020
Member
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
Looks solid!
I imagine there might be a chance that we missed some rewrites, but nothing we can fix in the future. (Just a hypothesis based on the nuances of CSS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #22774
The build will fail at the moment becauseUpdate: should be able to build correctly now, as that package is now published on the dotnet-eng feed.Microsoft.Css.Parserisn't available in any of our package sources, but I've restored it locally and it works.This is a new Razor SDK command. Given a set of
(inputfilename, outputfilename, scopeid)triplets, it reads all the input files, and writes them back out to the corresponding output filenames, having mutated the contents to inject the scopeid strings in the right places to achieve CSS isolation.This should fit in with the broader pattern of using
DotNetToolTaskand implementing support for incrementalism within that wrapper task.