Add support for gzip compression during build and publish #23611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.2 shipped with gzip compression during build and publish. During the port to 5.0, the build and publish pipeline was different and ended up only during brotli compression during publish. However, during build the app size is now up to 20MB. Statically compressing runtime assets during build reduces the payload size to about 8.5 MB. This should help with faster initial boot ups and perception.
ghost
added
the
area-mvc
javiercn
approved these changes
Jul 2, 2020
Member
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
I couldn't have written it better!
mkArtakMSFT
added
the
ask-mode
src/Razor/Microsoft.NET.Sdk.Razor/integrationtests/Wasm/WasmBuildIntegrationTest.cs
Show resolved
Hide resolved
| <!-- | ||
| Compress referenced binaries using GZip during build. This skips files such as the project's assemblies | ||
| that change from build to build. Runtime assets contribute to the bulk of the download size. Compressing it | ||
| has the most benefit while avoiding any ongoing costs to the dev inner loop. |
Member
There was a problem hiding this comment.
Does "skip the project's own assemblies" really make the build perceptibly faster? I would have thought that gzipping a few hundred KB (for a fairly large app assembly) would be basically instant.
Not suggesting blocking this PR on that question. I just want to understand.
Contributor
Author
There was a problem hiding this comment.
I thought I had numbers that showed this was going be expensive, but calling GZip on most .NET assemblies, including ones that are several 100kb, seems to be in the order of a few ms. There's a few outliers (like S.T.Encodings takes about 20-30ms for a < 1MB input file), but a few 100kb sized blazor app is a blip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.2 shipped with gzip compression during build and publish. During the port to 5.0, the build and publish
pipeline was different and ended up only porting brotli compression during publish. However, there's concern that people are going to balk at the built app size which is now 20MB. Statically compressing runtime assets during build reduces the payload size to about 8.5 MB.
Before
After