Better retries #22898
Merged
Better retries #22898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from eng/common/tools.ps1
ghost
added
the
area-infrastructure
Member
|
👀 |
Member
Author
|
Gist of the change is added a new download.ps1 helper that does 5 retries with exponential backoff (copied from eng/common/tools.ps1), everywhere we were using invoke-webrequest directly has been updated to use this |
dougbu
suggested changes
Jun 16, 2020
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
This covers the *.ps1 files nicely.
We also need to add --retries 5 to all curl commands in *.sh files. Are you planning to do that in a separate PR❔
Member
Author
|
Yeah I'll do the non ps1's in a different PR |
dougbu
suggested changes
Jun 16, 2020
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
One thing to test and maybe fix. Otherwise, looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20577