Small memory allocation optimization in DefaultRazorTagHelperBinderPh… #22887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase.TrySplitNamespaceAndType This method allocated multiple strings on every invocation when they were rarely needed. With this change, I see a reduction in memory allocated during RazorProjectEngine.ProcessDesignTime of 1.4%.
ghost
added
the
area-mvc
dougbu
reviewed
Jun 12, 2020
| typeName = GetTextSpanContent(typeNameTextSpan, typeName); | ||
| } | ||
| if (!TrySplitNamespaceAndType(typeName, out var _, out var className)) | ||
| if (!TrySplitNamespaceAndType(typeName, out var _, out var classNameTextSpan)) |
Contributor
There was a problem hiding this comment.
Minor but this method could exit earlier if the original typeName were empty. No reason to get the string content of an empty span. #WontFix
Contributor
Author
There was a problem hiding this comment.
I didn't want to affect the functionality of this code, as there are some subtle behaviors here. Let me know if you think it's worth pursuing.
In reply to: 439606336 [](ancestors = 439606336)
Contributor
There was a problem hiding this comment.
Not my code. I defer to other reviewers 😺
NTaylorMullen
approved these changes
Jun 12, 2020
ajaybhargavb
approved these changes
Jun 12, 2020
src/Razor/Microsoft.AspNetCore.Razor.Language/src/DefaultRazorTagHelperBinderPhase.cs
Show resolved
Hide resolved
src/Razor/Microsoft.AspNetCore.Razor.Language/src/DefaultRazorTagHelperBinderPhase.cs
Show resolved
Hide resolved
|
|
||
| // Internal for testing. | ||
| internal static bool TrySplitNamespaceAndType(string fullTypeName, out string @namespace, out string typeName) | ||
| internal static bool TrySplitNamespaceAndType(string fullTypeName, out TextSpan @namespace, out TextSpan typeName) |
ToddGrun
deleted the
dev/toddgrun/TrySplitNamespaceAndTypeAllocatesTooMuch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ase.TrySplitNamespaceAndType
This method allocated multiple strings on every invocation when they were rarely needed. With this change, I see a reduction in memory allocated during RazorProjectEngine.ProcessDesignTime of 1.4%.