Skip to content

Improve XML docs for ActionResultObjectValueAttribute #22479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2020
Merged

Improve XML docs for ActionResultObjectValueAttribute #22479

merged 1 commit into from
Jun 3, 2020

Conversation

@scottaddie
Copy link
Member

@scottaddie scottaddie commented Jun 2, 2020 •
edited
Loading

Adds missing labels and <code> elements for the examples and fixes minor grammatical issues. Also provides more complete sample code.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 2, 2020
pranavkm
pranavkm approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scottaddie

@pranavkm pranavkm merged commit e7ca49c into dotnet:master Jun 3, 2020
@pranavkm pranavkm added this to the 5.0.0-preview7 milestone Jun 3, 2020
@scottaddie scottaddie deleted the patch-2 branch June 3, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Milestone

5.0.0-preview7

Development

Successfully merging this pull request may close these issues.

2 participants

@scottaddie @pranavkm