Skip to content

Reuse model binders #22391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Reuse model binders #22391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
787aed4
Reuse model binders
martincostello May 30, 2020
00108c9
Make fields readonly
martincostello Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Mvc/Mvc.Core/src/ModelBinding/Binders/CancellationTokenModelBinderProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
/// </summary>
public class CancellationTokenModelBinderProvider : IModelBinderProvider
{
// CancellationTokenModelBinder does not have any state. Re-use the same instance for binding.

private readonly CancellationTokenModelBinder _modelBinder = new CancellationTokenModelBinder();

/// <inheritdoc />
public IModelBinder GetBinder(ModelBinderProviderContext context)
{
Expand All @@ -21,7 +25,7 @@ public IModelBinder GetBinder(ModelBinderProviderContext context)

if (context.Metadata.ModelType == typeof(CancellationToken))
{
return new CancellationTokenModelBinder();
return _modelBinder;
}

return null;
Expand Down
6 changes: 5 additions & 1 deletion src/Mvc/Mvc.Core/src/ModelBinding/Binders/ServicesModelBinderProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding.Binders
/// </summary>
public class ServicesModelBinderProvider : IModelBinderProvider
{
// ServicesModelBinder does not have any state. Re-use the same instance for binding.

private readonly ServicesModelBinder _modelBinder = new ServicesModelBinder();

/// <inheritdoc />
public IModelBinder GetBinder(ModelBinderProviderContext context)
{
Expand All @@ -21,7 +25,7 @@ public IModelBinder GetBinder(ModelBinderProviderContext context)
if (context.BindingInfo.BindingSource != null &&
context.BindingInfo.BindingSource.CanAcceptDataFrom(BindingSource.Services))
{
return new ServicesModelBinder();
return _modelBinder;
}

return null;
Expand Down