Remove the need for a global lock when building or publishing a project #21753
Conversation
pranavkm
commented
May 12, 2020
pranavkm
commented
- Change template test build and publish to not perform dotnet restore
- Remove locking requirements for build and publish
- Increase timeout for dotnet new operations since it's network bound
* Change template test build and publish to not perform dotnet restore * Remove locking requirements for build and publish * Increase timeout for dotnet new operations since it's network bound
ghost
added
the
area-mvc
|
If you feel this does in fact fix the reliance on the |
While I think it should be fixed, we'll let DOI make that call. |
ryanbrandenburg
left a comment
ryanbrandenburg
left a comment
There was a problem hiding this comment.
This seems fine except for the very-long timeout. Probably wanna re-run it a couple times just to be sure nothing falls out.
| public async Task WaitAsync(TimeSpan? timeout = null) | ||
| { | ||
| timeout ??= TimeSpan.FromMinutes(2); | ||
| timeout ??= TimeSpan.FromMinutes(20); |
There was a problem hiding this comment.
That seems excessive...
There was a problem hiding this comment.
I know, but these used to wait indefinitely, so it's a minor improvement over that.
There was a problem hiding this comment.
What goes wrong if they only wait 2 minutes?
There was a problem hiding this comment.
When I added these timeouts here, the build passed a few times successfully on public AzDo, and promptly failed in the internal Azdo. This of course included the time it takes to build \ publish which is being changed here. What I'm going with here is that it's hard to pick a reasonable time, but we also do not want tests to fail just because restore took too long that one time.
