Add JSON extension methods to request and response

[JamesNK]

Fixes #17160

• ReadFromJsonAsync
• WriteAsJsonAsync
• HasJsonContent
• Configure default JsonSerializerOptions
• MVC uses default JsonSerializerOptions as base
• SignalR uses default JsonSerializerOptions as base
• Write XML docs
• docs.microsoft.com docs - docs issue created: Add documentation for new HttpContext JSON extension methods in 5.0 AspNetCore.Docs#18623

[JamesNK]

I've added support for MVC's JsonOptions to use Http.Json's JsonOptions as its base.

Does it make sense for SignalR to do the same thing? SignalR's JSON protocol is independent of ASP.NET Core. It can run on the server or the client.

[davidfowl]

Does it make sense for SignalR to do the same thing? SignalR's JSON protocol is independent of ASP.NET Core. It can run on the server or the client.

I'm on the fence, I think customers do want a single way to configure the server defaults. @BrennanConroy and @halter73 any suggestions?

[JamesNK]

If SignalR did look to JsonOptions as a source of truth, does a client created on a server pick up what the server is configured when serializing its messages as JSON to send to another server?

e.g. you're calling SignalR from a server and the server has been configured so that Enum instances are serialized as strings. Does the SignalR client automatically start serializing messages with Enum instances as strings?

I think this would be unexpected behavior.

[davidfowl]

If SignalR did look to JsonOptions as a source of truth, does a client created on a server pick up what the server is configured when serializing its messages as JSON to send to another server?

Maybe just the server? But this brings up more questions about what the HttpClient factory should do or rather, how to make it read these same options.

I think we should leave this alone and separate from SignalR and MVC. If MVC happen to use this API then it will get the appropriate options but we shouldn't import these options everywhere.

That's my current take until we get more feedback.

[halter73]

Even on the server, I think it should be possible for MVC and SignalR to use different JSON options.

[JamesNK]

🆙 📅

[pranavkm]

You might have to use https://github.com/dotnet/aspnetcore/pull/22275/files#diff-157077aa157aa701d4b4a1419f32a298R1 trick to get the ref assembly working. #22323 should fix it for all ref assemblies.

[ghost]

Hello @JamesNK!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

Apologies, while this PR appears ready to be merged, it looks like release/5.0-preview6 is a protected branch and I have not been granted permission to perform the merge.