Avoid changing global state in CI runs II #21643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
dougbu
force-pushed
the
dougbu/add.DOTNET_CLI_HOME.II
branch
from
9cf3936 to
0fd4df3
Compare
dougbu
force-pushed
the
dougbu/add.DOTNET_CLI_HOME.II
branch
6 times, most recently
from
6a83e0a to
8f98e95
Compare
JunTaoLuo
approved these changes
May 16, 2020
dougbu
force-pushed
the
dougbu/add.DOTNET_CLI_HOME.II
branch
3 times, most recently
from
95bcbdd to
6615322
Compare
- move `dotnet` tools into `$PWD/.dotnet/tools/` - add `dotnet` tools to `$env:PATH` - install `jq` in `$PWD/.tools/` - install `nginx` in `$PWD/.tools/nginx/` nits: - remove an extra (incorrect) `$env:JAVA_HOME` setting - build.ps1 finds a local JDK and sets this variable (and `$env:PATH`) properly - avoid `'$(SELENIUMPROCESSTRACKINGFOLDER)' == '\artifacts\tmp\selenium\'` - `$(BuildDirectory)` was normally the empty string (w/o fix) - use `$(BuildDirectory)` a bit more
…ings on CI - artifacts/log is often empty when binary logs are disabled - no tests create *.trx files - don't have Java test results either - only test jobs need test results published
dougbu
force-pushed
the
dougbu/add.DOTNET_CLI_HOME.II
branch
from
6615322 to
81760d6
Compare
Contributor
Author
|
@JunTaoLuo I changed this PR significantly since your review. I also added a commit avoiding some of the warnings that happen in every build. Please review again. /cc @dotnet/aspnet-build |
JunTaoLuo
approved these changes
May 22, 2020
Contributor
JunTaoLuo
left a comment
JunTaoLuo
left a comment
There was a problem hiding this comment.
Looks good, just a couple none blocking questions
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnettools into.dotnet/dotnettools to$PATHjqin.tools/nginxin.tools/nginx