Avoid changing global state in CI runs #21602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set `$env:DOTNET_CLI_HOME` because we need to install global tools in this repo - without this, we see `dotnet-serve` installation failures on unclean machines
ghost
added
the
area-infrastructure
Contributor
Author
|
@dotnet/efcore I'm not sure whether a similar change would be useful in dotnet/ef6 or dotnet/efcore. Does anything in your pipeline install a global tool❔ @javiercn, @NTaylorMullen, @pranavkm what about aspnetcore-tooling❔ (The repos that aren't dotnet/aspnetcore don't use .config/dotnet-tools.json. But, that isn't clear enough to be sure about global tool use.) |
Contributor
|
@NTaylorMullen \ @ajaybhargavb would know best, but afaik tooling doesn't require a global tool. |
pranavkm
approved these changes
May 8, 2020
sebastienros
approved these changes
May 8, 2020
captainsafia
approved these changes
May 8, 2020
Member
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
Thanks for taking the time to do this.
Contributor
Author
|
Turns out this change was incomplete because I didn't add the .dotnet/tools directory to the path. It'll work until the 'blazor-wasm' branch is merged into 'master'. I'll send a follow up tomorrow. |
dougbu
added a commit
that referenced
this pull request
May 11, 2020
- set `$env:DOTNET_CLI_HOME` because we need to install global tools in this repo - without this, we see `dotnet-serve` installation failures on unclean machines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$env:DOTNET_CLI_HOMEbecause we need to install global tools in this repodotnet-serveinstallation failures on unclean machines