Skip to content

Add missing curl/wget dependency to "Build ASP.NET Core from Source" doc page #21431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2020
Merged

Add missing curl/wget dependency to "Build ASP.NET Core from Source" doc page #21431

merged 2 commits into from
May 4, 2020

Conversation

@MaxHorstmann
Copy link
Contributor

@MaxHorstmann MaxHorstmann commented May 2, 2020

Adds missing curl/wget dependency to Build ASP.NET Core from Source doc page.

Addresses #21430, which has more details.

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 4, 2020
@Pilchie Pilchie requested a review from dougbu May 4, 2020 18:06
dougbu
dougbu approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine.

For my own curiosity, what Linux or macOS installations lack both curl and wget after the other requirements are satisfied?

@MaxHorstmann
Copy link
Contributor Author

MaxHorstmann commented May 4, 2020

@dougbu macOS has curl, but several Linux distros such as Ubuntu don't come with either pre-installed. If you have Docker installed, you can run the repro steps I added to #21430 to confirm.

@dougbu
Copy link
Contributor

dougbu commented May 4, 2020

Thanks very much @MaxHorstmann❕❕

@dougbu dougbu merged commit a39d9f2 into dotnet:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaxHorstmann @dougbu @Pilchie