Skip to content

Conversation

@sanyam142mittal
Copy link
Contributor

JAVA_HOME environment variable is required by Gradle. Gradle compilation fails otherwise.

Summary of the changes (Less than 80 chars)

  • Updates docs/BuildFromSource.md to add instruction for adding JAVA_HOME env variable

No bug raised

JAVA_HOME environment variable is required by Gradle. Gradle compilation fails otherwise.
@Pilchie Pilchie requested review from BrennanConroy and dougbu April 30, 2020 17:30
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion to make it clear this setting is often not necessary. This is a good doc improvement with or without that.

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 1, 2020
@dougbu
Copy link
Contributor

dougbu commented May 11, 2020

@BrennanConroy please merge if you agree this is ready. @sanyam142mittal thanks very much❕

@BrennanConroy BrennanConroy merged commit cb83d5d into dotnet:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants