Skip to content

[Helix] Don't fail fast on ef tool install issues (may be already installed) #20958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 18, 2020
Merged

[Helix] Don't fail fast on ef tool install issues (may be already installed) #20958

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
990055f
Make Win8/7 required for debugging [skip ci]
HaoK Apr 17, 2020
0ac62af
Shell dotnet in runtest to looksie
HaoK Apr 17, 2020
a8ad723
Add restore sources
HaoK Apr 17, 2020
c6e4f27
Allow ef tool install to fail
HaoK Apr 17, 2020
5f01c10
Update runtests.cmd
HaoK Apr 17, 2020
e2df991
Update Helix.Common.props
HaoK Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eng/helix/content/RunTests/TestRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,8 @@ await ProcessUtil.RunAsync($"{Options.DotnetRoot}/dotnet",
$"tool install dotnet-ef --global --version {Options.EfVersion}",
environmentVariables: EnvironmentVariables,
outputDataReceived: Console.WriteLine,
errorDataReceived: Console.Error.WriteLine);
errorDataReceived: Console.Error.WriteLine,
throwOnError: false); // EF tool is sometimes already installed so we can ignore this failure

// ';' is the path separator on Windows, and ':' on Unix
Options.Path += RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? ";" : ":";
Expand Down