Fix TimerAwaitable rooting #20937
Merged
Fix TimerAwaitable rooting #20937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This fixes an issue where components that use timer awaitable currently need to be explicitly stopped and disposed for it to be unrooted. This makes it possible to write a finalizer.
davidfowl
requested review from
BrennanConroy,
analogrelay and
halter73
as code owners
ghost
added
the
analogrelay
reviewed
Apr 17, 2020
Comment on lines
+20
to
+21
| GC.Collect(); | ||
| GC.WaitForPendingFinalizers(); |
Contributor
There was a problem hiding this comment.
Suggested change
| GC.Collect(); | |
| GC.WaitForPendingFinalizers(); | |
| GC.Collect(); | |
| GC.WaitForPendingFinalizers(); | |
| if (tcs.Task.IsCompleted) | |
| { | |
| return; | |
| } |
That way we can exit early if the task finishes early.
BrennanConroy
approved these changes
Apr 17, 2020
src/SignalR/clients/csharp/Client/test/UnitTests/TimerAwaitableTests.cs
Outdated
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pattern exists in a couple more places in the BCL:
It usually affects client APIs where disposal of resources happen if something is unreferenced.