See what happens with blazor build in helix #18962

HaoK · 2020-02-11T21:26:27Z

No description provided.

HaoK · 2020-02-11T22:48:45Z

@pranavkm I reenabled these tests on helix but it looks like they will need some rejiggering to work, as they are looking for the files based on build time locations, can you see if you can make any tactical changes to make these tests work on helix (its valid to copy the test assets into the public directory, and then have the test look for them using a relative path to the runtime directory).

only 13 tests are failing:

A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:01.14]     Microsoft.AspNetCore.Blazor.Build.ProjectDirectoryTest.ProjectDirectory_IsNotSetToBePreserved [FAIL]
[xUnit.net 00:00:01.17]     Microsoft.AspNetCore.Blazor.Build.RuntimeDependenciesResolverTest.FindsReferenceAssemblyGraph_ForStandaloneApp [SKIP]
[xUnit.net 00:00:01.19]     Microsoft.AspNetCore.Blazor.Build.BuildIncrementalismTest.Build_WithLinker_IsIncremental [FAIL]
  X Microsoft.AspNetCore.Blazor.Build.ProjectDirectoryTest.ProjectDirectory_IsNotSetToBePreserved [12ms]
  Error Message:
   System.InvalidOperationException : Could not find project at 'F:\workspace\_work\1\s\src\Components\Blazor\Build\testassets\standalone'
  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.ProjectDirectory.Create(String projectName, String baseDirectory, String[] additionalProjects) in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectory.cs:line 42
   at Microsoft.AspNetCore.Blazor.Build.ProjectDirectoryTest.ProjectDirectory_IsNotSetToBePreserved() in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectoryTest.cs:line 14
  ! Microsoft.AspNetCore.Blazor.Build.RuntimeDependenciesResolverTest.FindsReferenceAssemblyGraph_ForStandaloneApp [1ms]
  X Microsoft.AspNetCore.Blazor.Build.BuildIncrementalismTest.Build_WithLinker_IsIncremental [9ms]
  Error Message:
   System.InvalidOperationException : Could not find project at 'F:\workspace\_work\1\s\src\Components\Blazor\Build\testassets\standalone'
  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.ProjectDirectory.Create(String projectName, String baseDirectory, String[] additionalProjects) in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectory.cs:line 42
   at Microsoft.AspNetCore.Blazor.Build.BuildIncrementalismTest.Build_WithLinker_IsIncremental() in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/BuildIncrementalismTest.cs:line 15
--- End of stack trace from previous location ---
[xUnit.net 00:00:05.69]     Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_WithDefaultSettings_Works [FAIL]
[xUnit.net 00:00:05.69]     Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_HostedApp_WithNoBuild_Works [FAIL]
[xUnit.net 00:00:05.70]     Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_WithLinkOnBuildDisabled_Works [FAIL]
[xUnit.net 00:00:05.70]     Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_WithNoBuild_Works [FAIL]
[xUnit.net 00:00:05.71]     Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_SatelliteAssemblies_AreCopiedToBuildOutput [FAIL]
[xUnit.net 00:00:05.71]     Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_HostedApp_Works [FAIL]
  X Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_WithDefaultSettings_Works [3ms]
  Error Message:
   System.InvalidOperationException : Could not find project at 'F:\workspace\_work\1\s\src\Components\Blazor\Build\testassets\standalone'
  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.ProjectDirectory.Create(String projectName, String baseDirectory, String[] additionalProjects) in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectory.cs:line 42
   at Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_WithDefaultSettings_Works() in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/PublishIntegrationTest.cs:line 16
--- End of stack trace from previous location ---
  X Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_HostedApp_WithNoBuild_Works [3ms]
  Error Message:
   System.InvalidOperationException : Could not find project at 'F:\workspace\_work\1\s\src\Components\Blazor\Build\testassets\blazorhosted'
  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.ProjectDirectory.Create(String projectName, String baseDirectory, String[] additionalProjects) in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectory.cs:line 42
   at Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_HostedApp_WithNoBuild_Works() in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/PublishIntegrationTest.cs:line 189
--- End of stack trace from previous location ---
  X Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_WithLinkOnBuildDisabled_Works [3ms]
  Error Message:
   System.InvalidOperationException : Could not find project at 'F:\workspace\_work\1\s\src\Components\Blazor\Build\testassets\standalone'
  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.ProjectDirectory.Create(String projectName, String baseDirectory, String[] additionalProjects) in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectory.cs:line 42
   at Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_WithLinkOnBuildDisabled_Works() in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/PublishIntegrationTest.cs:line 84
--- End of stack trace from previous location ---
  X Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_WithNoBuild_Works [3ms]
  Error Message:
   System.InvalidOperationException : Could not find project at 'F:\workspace\_work\1\s\src\Components\Blazor\Build\testassets\standalone'
  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.ProjectDirectory.Create(String projectName, String baseDirectory, String[] additionalProjects) in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectory.cs:line 42
   at Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_WithNoBuild_Works() in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/PublishIntegrationTest.cs:line 46
--- End of stack trace from previous location ---
  X Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_SatelliteAssemblies_AreCopiedToBuildOutput [3ms]
  Error Message:
   System.InvalidOperationException : Could not find project at 'F:\workspace\_work\1\s\src\Components\Blazor\Build\testassets\standalone'
  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.ProjectDirectory.Create(String projectName, String baseDirectory, String[] additionalProjects) in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectory.cs:line 42
   at Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_SatelliteAssemblies_AreCopiedToBuildOutput() in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/PublishIntegrationTest.cs:line 119
--- End of stack trace from previous location ---
  X Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_HostedApp_Works [3ms]
  Error Message:
   System.InvalidOperationException : Could not find project at 'F:\workspace\_work\1\s\src\Components\Blazor\Build\testassets\blazorhosted'
  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.ProjectDirectory.Create(String projectName, String baseDirectory, String[] additionalProjects) in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectory.cs:line 42
   at Microsoft.AspNetCore.Blazor.Build.PublishIntegrationTest.Publish_HostedApp_Works() in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/PublishIntegrationTest.cs:line 148
--- End of stack trace from previous location ---
[xUnit.net 00:00:06.93]     Microsoft.AspNetCore.Blazor.Build.Test.ComponentRenderingRazorIntegrationTest.Render_HtmlBlock_Integration [SKIP]
  ! Microsoft.AspNetCore.Blazor.Build.Test.ComponentRenderingRazorIntegrationTest.Render_HtmlBlock_Integration [1ms]
[xUnit.net 00:00:07.23]     Microsoft.AspNetCore.Blazor.Build.Test.ComponentRenderingRazorIntegrationTest.Render_Component_HtmlEncoded [SKIP]
  ! Microsoft.AspNetCore.Blazor.Build.Test.ComponentRenderingRazorIntegrationTest.Render_Component_HtmlEncoded [1ms]
[xUnit.net 00:00:07.91]     Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_WithLinkOnBuildDisabled_Works [FAIL]
  X Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_WithLinkOnBuildDisabled_Works [3ms]
  Error Message:
   System.InvalidOperationException : Could not find project at 'F:\workspace\_work\1\s\src\Components\Blazor\Build\testassets\standalone'
  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.ProjectDirectory.Create(String projectName, String baseDirectory, String[] additionalProjects) in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectory.cs:line 42
   at Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_WithLinkOnBuildDisabled_Works() in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/BuildIntegrationTest.cs:line 54
--- End of stack trace from previous location ---
[xUnit.net 00:00:07.92]     Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_WithDefaultSettings_Works [FAIL]
[xUnit.net 00:00:07.93]     Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_WithBlazorLinkOnBuildFalse_SatelliteAssembliesAreCopiedToBuildOutput [FAIL]
[xUnit.net 00:00:07.94]     Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_Hosted_Works [FAIL]
[xUnit.net 00:00:07.94]     Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_SatelliteAssembliesAreCopiedToBuildOutput [FAIL]
  X Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_WithDefaultSettings_Works [3ms]
  Error Message:
   System.InvalidOperationException : Could not find project at 'F:\workspace\_work\1\s\src\Components\Blazor\Build\testassets\standalone'
  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.ProjectDirectory.Create(String projectName, String baseDirectory, String[] additionalProjects) in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectory.cs:line 42
   at Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_WithDefaultSettings_Works() in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/BuildIntegrationTest.cs:line 16
--- End of stack trace from previous location ---
  X Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_WithBlazorLinkOnBuildFalse_SatelliteAssembliesAreCopiedToBuildOutput [15ms]
  Error Message:
   System.InvalidOperationException : Could not find project at 'F:\workspace\_work\1\s\src\Components\Blazor\Build\testassets\standalone'
  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.ProjectDirectory.Create(String projectName, String baseDirectory, String[] additionalProjects) in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectory.cs:line 42
   at Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_WithBlazorLinkOnBuildFalse_SatelliteAssembliesAreCopiedToBuildOutput() in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/BuildIntegrationTest.cs:line 108
--- End of stack trace from previous location ---
  X Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_Hosted_Works [3ms]
  Error Message:
   System.InvalidOperationException : Could not find project at 'F:\workspace\_work\1\s\src\Components\Blazor\Build\testassets\blazorhosted'
  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.ProjectDirectory.Create(String projectName, String baseDirectory, String[] additionalProjects) in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectory.cs:line 42
   at Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_Hosted_Works() in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/BuildIntegrationTest.cs:line 35
--- End of stack trace from previous location ---
  X Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_SatelliteAssembliesAreCopiedToBuildOutput [2ms]
  Error Message:
   System.InvalidOperationException : Could not find project at 'F:\workspace\_work\1\s\src\Components\Blazor\Build\testassets\standalone'
  Stack Trace:
     at Microsoft.AspNetCore.Blazor.Build.ProjectDirectory.Create(String projectName, String baseDirectory, String[] additionalProjects) in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/ProjectDirectory.cs:line 42
   at Microsoft.AspNetCore.Blazor.Build.BuildIntegrationTest.Build_SatelliteAssembliesAreCopiedToBuildOutput() in /_/src/Components/Blazor/Build/test/BuildIntegrationTests/BuildIntegrationTest.cs:line 78
--- End of stack trace from previous location ---
Results File: C:\h\w\9EC808C7\w\BB7F09FA\e\TestResults\TestResults.xml

Test Run Failed.
Total tests: 114
     Passed: 98
     Failed: 13
    Skipped: 3
 Total time: 10.3155 Seconds

HaoK · 2020-03-19T21:49:32Z

@pranavkm I fixed some the path issues, now it looks like there are some harder ones where the test projects are referencing ReferenceBlazorBuildFromSource.props which has paths hardcoded, so its looking for a non existent versions.props. Any ideas how to hijack this logic to make it look for a hardcoded path since we can include the necessary files in the helix payload so relative paths would work always.

Microsoft.AspNetCore.Blazor.Build.Assert+BuildFailedException : Build failed.

C:\h\w\AB9C096C\p\sdk\x64\dotnet.exe msbuild /nr:false /bl /t:Publish /p:Configuration=Release

Process execution diagnostics:

Process output:

Microsoft (R) Build Engine version 16.6.0-preview-20105-01+5d872c945 for .NET Core

Copyright (C) Microsoft Corporation. All rights reserved.

C:\h\w\AB9C096C\p\sdk\x64\sdk\5.0.100-preview.2.20120.3\MSBuild.dll -distributedlogger:Microsoft.DotNet.Tools.MSBuild.MSBuildLogger,C:\h\w\AB9C096C\p\sdk\x64\sdk\5.0.100-preview.2.20120.3\dotnet.dll*Microsoft.DotNet.Tools.MSBuild.MSBuildForwardingLogger,C:\h\w\AB9C096C\p\sdk\x64\sdk\5.0.100-preview.2.20120.3\dotnet.dll -maxcpucount -verbosity:m /bl /nr:false /p:Configuration=Release /t:Publish .\standalone.csproj

C:\Users\runner\AppData\Local\Temp\BlazorBuild\uahkjw3o.ftu\standalone\Directory.Build.props(17,5): error MSB4019: The imported project "F:\workspace_work\1\s\eng\Versions.props" was not found. Confirm that the expression in the Import declaration "F:\workspace_work\1\s\eng\Versions.props" is correct, and that the file exists on disk. [C:\Users\runner\AppData\Local\Temp\BlazorBuild\uahkjw3o.ftu\standalone\standalone.csproj]

pranavkm · 2020-03-19T22:23:23Z

We could make this line conditional:

https://github.com/dotnet/aspnetcore/blob/master/src/Components/Blazor/Build/testassets/Directory.Build.props#L17

-    <Import Project="$(RepoRoot)eng\Versions.props" />
+   <Import Project="$(RepoRoot)eng\Versions.props" Condition="Exists($(RepoRoot)eng\Versions.props))" />
+   <Import Project="$(SomeMagicDirThatExistsInHelix)Versions.props" Condition="Exists($(SomeMagicDirThatExistsInHelix)Versions.props))" />

And copy the Versions.props to the packaging output. Is that reasonable?

HaoK · 2020-03-20T22:35:41Z

@pranavkm tried your suggestion and it looks like it might cause issues with restore?

src\Components\Blazor\Build\testassets\standalone\standalone.csproj(0,0): error NU1103: Unable to find a stable package Microsoft.AspNetCore.Blazor.Mono with version 
  - Found 26 version(s) in dotnet5 [ Nearest version: 3.1.0-preview4.19575.3 ]
  - Found 13 version(s) in nuget.org [ Nearest version: 0.8.0-preview-20190204.1 ]
  - Found 4 version(s) in dotnet-core [ Nearest version: 0.10.0-preview6.19273.7 ]
  - Found 0 version(s) in aspnetcore-dev
  - Found 0 version(s) in aspnetcore-tools
  - Found 0 version(s) in roslyn-tools
  - Found 0 version(s) in roslyn
  - Found 0 version(s) in dotnet-eng
  - Found 0 version(s) in dotnet5-transport

captainsafia · 2020-06-08T19:17:20Z

Rebasing to bring in the latest changes now that the blazor-wasm branch is merged. Let's see what chaos ensues....

captainsafia · 2020-07-31T17:24:17Z

Closing this PR.

Our build tests have change a bit now that we have a Blazor WASM SDK. Will open a new PR with changes.

ghost added the area-blazor Includes: Blazor, Razor Components label Feb 11, 2020

pranavkm self-assigned this Mar 9, 2020

pranavkm closed this Mar 9, 2020

pranavkm reopened this Mar 9, 2020

pranavkm closed this Mar 10, 2020

pranavkm reopened this Mar 10, 2020

pranavkm force-pushed the helix/blazor-build branch from ea2fcd3 to 20c3e46 Compare March 10, 2020 16:24

This was referenced Mar 23, 2020

Flaky test RequestHeaders_MultipleFrames_Accepted #20087

Closed

Flaky test FlowControl_ParallelStreams_FirstInFirstOutOrder #20088

Closed

Flaky test ProcessAsync_AwaitersUseTheResultOfExecutor #20089

Closed

HaoK force-pushed the helix/blazor-build branch from 6bca380 to 8fbb073 Compare May 4, 2020 21:55

captainsafia mentioned this pull request May 6, 2020

Get Blazor SDK tests working on Helix #21547

Closed

captainsafia assigned captainsafia and unassigned pranavkm May 6, 2020

captainsafia force-pushed the helix/blazor-build branch 3 times, most recently from cf1fd3d to 975ea59 Compare May 7, 2020 21:59

captainsafia closed this May 7, 2020

captainsafia reopened this May 7, 2020

captainsafia force-pushed the helix/blazor-build branch from 975ea59 to 4aa4bfb Compare May 7, 2020 22:44

captainsafia closed this May 8, 2020

captainsafia reopened this May 8, 2020

captainsafia force-pushed the helix/blazor-build branch 4 times, most recently from 1fd29d6 to facd961 Compare May 9, 2020 00:38

HaoK and others added 11 commits June 8, 2020 12:11

Include versions.props in helix payload

0b5c27b

Update Directory.Build.props

5f37b0c

Update Directory.Build.props

4fb54da

Update Directory.Build.props

e5756c9

Update Directory.Build.props

7b6870b

Update Directory.Build.props

84a725b

Update Directory.Build.props

a20713e

Update Directory.Build.props

7631856

Hardcode versions to see if this unblocks things

1c4b8a9

Use versions available on nuget

4df5079

Rework file resolution path

7d916aa

captainsafia force-pushed the helix/blazor-build branch from e7e425d to 7d916aa Compare June 8, 2020 19:16

captainsafia force-pushed the helix/blazor-build branch from 7560e56 to c4f8349 Compare June 8, 2020 22:05

Fix resolution for ReferenceBlazorBuildFromSource

a7b6962

captainsafia force-pushed the helix/blazor-build branch 5 times, most recently from 10c3977 to 6ea822f Compare June 9, 2020 17:42

Fix route for Microsoft.Net.Sdk.Razor.props

2bd2721

captainsafia force-pushed the helix/blazor-build branch from 6ea822f to 2bd2721 Compare June 9, 2020 18:39

captainsafia added 4 commits June 9, 2020 12:49

Looks for Sdk.props in current directory

3222bd7

Update Directory.Build.props

48e0e3c

Update Directory.Build.props

e749715

Change where Razor SDK is resolved

1d140df

captainsafia force-pushed the helix/blazor-build branch from 49c1820 to 1d140df Compare June 17, 2020 19:27

captainsafia closed this Jul 31, 2020

captainsafia deleted the helix/blazor-build branch September 16, 2020 07:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

See what happens with blazor build in helix #18962

See what happens with blazor build in helix #18962

Uh oh!

HaoK commented Feb 11, 2020

Uh oh!

HaoK commented Feb 11, 2020

Uh oh!

HaoK commented Mar 19, 2020 •

edited

Loading

Uh oh!

pranavkm commented Mar 19, 2020 •

edited

Loading

Uh oh!

HaoK commented Mar 20, 2020

Uh oh!

captainsafia commented Jun 8, 2020

Uh oh!

captainsafia commented Jul 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

See what happens with blazor build in helix #18962

See what happens with blazor build in helix #18962

Uh oh!

Conversation

HaoK commented Feb 11, 2020

Uh oh!

HaoK commented Feb 11, 2020

Uh oh!

HaoK commented Mar 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pranavkm commented Mar 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HaoK commented Mar 20, 2020

Uh oh!

captainsafia commented Jun 8, 2020

Uh oh!

captainsafia commented Jul 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HaoK commented Mar 19, 2020 •

edited

Loading

pranavkm commented Mar 19, 2020 •

edited

Loading