Skip to content

Set new HTTPS environment variable when using out of process #16724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 1, 2019
Merged

Set new HTTPS environment variable when using out of process #16724

merged 4 commits into from
Nov 1, 2019

Conversation

@jkotalik
Copy link
Contributor

@jkotalik jkotalik commented Nov 1, 2019

Same as #16713 except targeting 3.0

@Pilchie can we target this for 3.0.1?

@jkotalik jkotalik requested review from Tratcher and halter73 November 1, 2019 01:01
@jkotalik jkotalik requested a review from analogrelay as a code owner November 1, 2019 01:01
@jkotalik jkotalik added this to the 3.0.1 milestone Nov 1, 2019
@jkotalik jkotalik added area-servers feature-iis Includes: IIS, ANCM Servicing-consider Shiproom approval is required for the issue labels Nov 1, 2019
@jkotalik
Copy link
Contributor Author

jkotalik commented Nov 1, 2019

@aspnet/build in 3.0 now, do I need to update the patch.config file if the component is in the targeting pack?

@mmitche
Copy link
Member

mmitche commented Nov 1, 2019

@wtgodbe @JunTaoLuo For the patch config question

@wtgodbe
Copy link
Member

wtgodbe commented Nov 1, 2019

in 3.0 now, do I need to update the patch.config file if the component is in the targeting pack?

In general, yes. This time around we're explicitly building the targeting pack, but I'm not 100% sure if we also need to turn on the build of this individual component. @JunTaoLuo might have a more concrete answer on that.

@wtgodbe
Copy link
Member

wtgodbe commented Nov 1, 2019

Just chatted with @dougbu & @JunTaoLuo - you should add the affected project(s) to patchConfig.props

@jkotalik jkotalik requested a review from a team as a code owner November 1, 2019 18:24
@analogrelay
Copy link
Contributor

analogrelay commented Nov 1, 2019

This was approved over email, FYI. Updating labels. Please confirm with @aspnet/build that the branch is clear to merge in to.

@analogrelay analogrelay added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Nov 1, 2019
@mmitche
Copy link
Member

mmitche commented Nov 1, 2019

This was approved over email, FYI. Updating labels. Please confirm with @aspnet/build that the branch is clear to merge in to.

Clear to merge.

@jkotalik
Copy link
Contributor Author

jkotalik commented Nov 1, 2019

@Pilchie / @aspnet/build please merge (I not authorized to).

@mmitche mmitche merged commit 0f54cd7 into release/3.0 Nov 1, 2019
@mmitche mmitche deleted the jkotalik/HttpsRedirectionFix30 branch November 1, 2019 20:39
wtgodbe pushed a commit that referenced this pull request Nov 2, 2019
@jkotalik @wtgodbe
Set new HTTPS environment variable when using out of process (#16724)
755e95a 
* Set new HTTPS environment variable when using out of process

* Add https redirection test

* Update HttpsTests.cs

* Update patch config
@wtgodbe wtgodbe mentioned this pull request Nov 2, 2019
Closed
This was referenced Nov 6, 2019
Closed
Open
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73

@analogrelay analogrelay Awaiting requested review from analogrelay

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-iis Includes: IIS, ANCM Servicing-approved Shiproom has approved the issue

Projects

None yet

Milestone

3.0.1

Development

Successfully merging this pull request may close these issues.

7 participants

@jkotalik @mmitche @wtgodbe @analogrelay @Tratcher @amcasey