Skip to content

[master] Update dependencies from 4 repositories #16706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2019
Merged

[master] Update dependencies from 4 repositories #16706

merged 1 commit into from
Oct 31, 2019

Conversation

@BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy commented Oct 31, 2019 •
edited
Loading

Attempting to fix #15192

Missed arcade update, but would prefer to handle that in a new PR

@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 31, 2019
BrennanConroy
BrennanConroy commented Oct 31, 2019
View reviewed changes
eng/Version.Details.xml
<Dependencies>
<ProductDependencies>
<Dependency Name="Microsoft.AspNetCore.Blazor.Mono" Version="5.0.0-alpha1.19516.2">
<Dependency Name="Microsoft.AspNetCore.Blazor.Mono" Version="5.0.0-alpha1.19528.2">
Copy link
Member Author

@BrennanConroy BrennanConroy Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually downgraded this, will update it as part of #16580

@BrennanConroy BrennanConroy marked this pull request as ready for review October 31, 2019 20:29
@BrennanConroy BrennanConroy requested a review from dougbu as a code owner October 31, 2019 20:29
@BrennanConroy BrennanConroy requested a review from a team October 31, 2019 20:30
wtgodbe
wtgodbe approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the issue with #15192?

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Oct 31, 2019

It got borked by someone merging with master incorrectly. This PR has the correct deps updates (except arcade) and is only 2 files modified, that one is over 200 files modified...

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Oct 31, 2019

Oh, I also didn't pin the "Microsoft.Bcl.AsyncInterfaces" dep which the other PR did, not sure why it was done, and I haven't seen Doug for a while. Maybe it had something to do with arcade, I'll keep it in mind when doing that update.

@Pilchie
Copy link
Member

Pilchie commented Oct 31, 2019

It was pinned because the package isn't being produced in 5.0, so we wanted to use the last shipping package.

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Oct 31, 2019

It was pinned because the package isn't being produced in 5.0, so we wanted to use the last shipping package.

Ok, I'll fix that in another PR then

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Oct 31, 2019

Helix failures fixed in release/3.1, will be fixed in master once the 3.1 -> master PR is updated and merged

@BrennanConroy BrennanConroy merged commit 0e40856 into master Oct 31, 2019
@BrennanConroy BrennanConroy deleted the brecon/deps branch October 31, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@dougbu dougbu Awaiting requested review from dougbu

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BrennanConroy @Pilchie @wtgodbe