Skip to content

Drop IResponseCache async methods #15393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2019
Merged

Drop IResponseCache async methods #15393

merged 1 commit into from
Nov 4, 2019

Conversation

@Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Oct 25, 2019

Fixes #14993

@analogrelay
Copy link
Contributor

analogrelay commented Oct 26, 2019

cc @davidfowl

For context everyone, these async methods weren't actually doing anything async and were completely internal so @Kahbazi wondered if they should just be removed.

@jkotalik
Copy link
Contributor

jkotalik commented Oct 31, 2019

@JunTaoLuo to evaluate the risk of this change.

@jkotalik jkotalik added this to the 5.0.0-preview1 milestone Oct 31, 2019
@davidfowl
Copy link
Member

davidfowl commented Nov 1, 2019

Seems fine, this interface is internal and nothing was async.

JunTaoLuo
JunTaoLuo approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this looks good.

@JunTaoLuo JunTaoLuo merged commit 93432bd into dotnet:master Nov 4, 2019
@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Nov 4, 2019

Thanks for the contribution @Kahbazi !

@Kahbazi Kahbazi deleted the kahbazi/syncResponseCache branch December 10, 2020 11:48
@amcasey amcasey added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@analogrelay analogrelay Awaiting requested review from analogrelay

@Tratcher Tratcher Awaiting requested review from Tratcher

1 more reviewer

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JunTaoLuo JunTaoLuo

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares

Projects

None yet

Milestone

5.0.0-preview1

Development

Successfully merging this pull request may close these issues.

Change IResponseCache output to ValueTask

7 participants

@Kahbazi @analogrelay @jkotalik @davidfowl @JunTaoLuo @Pilchie @amcasey