Remove flaky test #15269
Remove flaky test #15269
Conversation
BrennanConroy
requested review from
analogrelay,
halter73 and
jkotalik
as code owners
| } | ||
|
|
||
| // A connection has been closed, try again. | ||
| string responseText = await SendRequestAsync(address); |
There was a problem hiding this comment.
Would this test be reliable if we removed just this last request? Looking at the last failure, that seems to be where the problem is.
Do we have any other tests that verifies HttpSysOptions.MaxConnections actually does anything?
There was a problem hiding this comment.
Do we have any other tests that verifies
HttpSysOptions.MaxConnectionsactually does anything?
No, but all we've implemented is passing the option to HttpSys. There is no functionality at our layer to verify.
There was a problem hiding this comment.
If we stopped passing the option to HttpSys, would any tests fail other than this one we're removing?
There was a problem hiding this comment.
Do we have any other tests that verifies
HttpSysOptions.MaxConnectionsactually does anything?
Yes
|
FYI I just updated another test that was verifying maxconnections and was flaky. |
amcasey
added
area-networking
Talked with @Tratcher and we think the test wasn't doing much and is flaky, so we're deleting it.