Run users options last #15121
Merged
Run users options last #15121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
requested review from
analogrelay,
halter73 and
mikaelm12
as code owners
halter73
reviewed
Oct 17, 2019
halter73
reviewed
Oct 17, 2019
Member
|
@anurse Should we put the Servicing-Consider label on this or something? |
Contributor
|
Approved in the issue, as per: #15085 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15085
Before, we were running users options first then running our options setup. This would override null values because we treat those as uninitialized. However, in cases like
MaximumReceiveMessageSize, null can also mean no-limit.Now, we run users options second. And for
MaximumReceiveMessageSizewe track if the user sets the value so we don't accidentally use the global value if they set it to null in the hub type specific options.@Pilchie for 3.1 bug fix approval.