Skip to content

Conversation

@javiercn
Copy link
Member

@javiercn javiercn commented Oct 16, 2019

There is an underlying issue here, which is a race condition between console logging and hosting logging.

In some rare cases the messages on the console for both get interleaved in wrong ways like dbugNow listening on: http://127.0.0.1:12857 which causes the test to fail finding the Listening on: pattern.

  • It prevents waiting indefinitely on the blocked collection, which is what caused the hangs.
  • It relaxes the pattern we use to find the message so that it can match simpler values and accounts for the message being preceded by other text in the output as in the example above.

Filed #15060 to triage the underlying hosting issue.

@javiercn javiercn force-pushed the javiercn/templates-mitigate-hangs branch from c3bc6c5 to 16555e7 Compare October 16, 2019 14:07
@javiercn javiercn added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Oct 16, 2019
@javiercn javiercn merged commit cad6e06 into release/3.1 Oct 16, 2019
@javiercn javiercn deleted the javiercn/templates-mitigate-hangs branch October 16, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants