Account for Layout ordering in Blazor #15001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server requires that clients send descriptors in sequence. Since MVC executes Layouts in an inside-out manner, modify the client to explicitly order descriptors Fixes #14474
Contributor
Author
|
No idea if this messes up a scenario, but all of the tests pass locally. |
Contributor
Author
|
Layouts in MVC are rendered inside out, consequently any components in a Layout page that appear before // _Layout.cshtml
<component type="Counter" />: sequence: 1
@RenderBody()
// Index.cshtml
<component type="Counter" />: sequence: 0
// _Layout.cshtml
<component type="Counter" />: sequence: 2This trips the deserialization when it sees out-of-order sequence numbers. |
javiercn
approved these changes
Oct 15, 2019
Member
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
This sounds like a great fix, it is how it was supposed to work, we just thought they were in order already.
I’m glad it wasn’t an issue with the viewcontext not being properly copied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server requires that clients send descriptors in sequence. Since MVC executes
Layouts in an inside-out manner, modify the client to explicitly order descriptors
Fixes #14474