Skip to content

Make InputBase respond to validation state notifications #14818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2019
Merged

Make InputBase respond to validation state notifications #14818

merged 2 commits into from
Oct 16, 2019

Conversation

@SteveSandersonMS
Copy link
Member

@SteveSandersonMS SteveSandersonMS commented Oct 8, 2019

Fixes #11914

@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Oct 8, 2019
javiercn
javiercn approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid!

@javiercn
Copy link
Member

javiercn commented Oct 16, 2019

Seems like the notification got stuck and can't be merged. @mkArtakMSFT I already signed off on this, so we can merge it for steve.

@javiercn javiercn added area-blazor Includes: Blazor, Razor Components and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Oct 16, 2019
@mkArtakMSFT
Copy link
Contributor

mkArtakMSFT commented Oct 16, 2019

Merging this as all the checks have succeeded. It's just some sync problem between GitHub and AzDO not showing it up.

@mkArtakMSFT mkArtakMSFT merged commit d3f1f5a into release/3.1 Oct 16, 2019
@mkArtakMSFT mkArtakMSFT deleted the stevesa/inputbase-subscribe-to-validation-state-notifications branch October 16, 2019 18:35
@SteveSandersonMS SteveSandersonMS mentioned this pull request Oct 17, 2019
Closed
@ryanelian ryanelian mentioned this pull request Jul 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiercn javiercn javiercn approved these changes

@rynowak rynowak Awaiting requested review from rynowak

Assignees

No one assigned

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SteveSandersonMS @javiercn @mkArtakMSFT @Pilchie