Sign Windows zips #11466
Merged
Sign Windows zips #11466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @johnbeisner This should resolve the issue we spoke about. I hope to get this in over the weekend so you have a build to work with on Monday. |
Eilon
added
the
area-infrastructure
dougbu
reviewed
Jun 23, 2019
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Well, I would have said 🚢🇮🇹 😈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signing of the windows zip was broken during the arcade conversion. Signing.props is imported by the Arcade Sign.proj. However, it doesn't import Directory.Build.props which defines
InstallersOutputPath.ArtifactsDiris defined so let's use that instead.I'll do a quick check of the other artifacts we expect to be signed.