Skip to content

[Blazor] NavigationManager API consolidation: NotFound method => NotifyNotFound() + NotFoundEvent => NotFound #61015

@hakenr

Description

@hakenr

Background and Motivation

I'm not sure how this got through the API review process (I'm not able to find the related discussion with possible justification), but the naming introduced in #60752 seems odd. The Event suffix in NotFoundEvent isn't commonly used in .NET APIs, and I believe it's considered inappropriate naming.

Proposed API

- public event EventHandler<EventArgs> NotFoundEvent
+ public event EventHandler<EventArgs> NotFound

- public virtual void NotFound()
+ public virtual void NotifyNotFound()

Reference

@ilonatommy @javiercn @SteveSandersonMS

(If you need a hand, I will prepare a PR for this.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    api-suggestionEarly API idea and discussion, it is NOT ready for implementationarea-blazorIncludes: Blazor, Razor Components

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions