Log on reset socket even if the logger is disabled

[haludi]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

If a SocketException exception is thrown while the SocketConnectionListener is accepting a new connection, the logger will still log, even if the logger is disabled

No IsEnabled check in the call position:
https://github.com/dotnet/aspnetcore/blob/release/7.0/src/Servers/Kestrel/Transport.Sockets/src/SocketConnectionListener.cs#L90
https://github.com/dotnet/aspnetcore/blob/release/6.0/src/Servers/Kestrel/Transport.Sockets/src/SocketConnectionListener.cs#L90

And explicitly skip the check on the code generation:
https://github.com/dotnet/aspnetcore/blob/release/7.0/src/Servers/Kestrel/Transport.Sockets/src/Internal/SocketsLog.cs#L50
https://github.com/dotnet/aspnetcore/blob/release/6.0/src/Servers/Kestrel/Transport.Sockets/src/Internal/SocketsTrace.cs#L70

Expected Behavior

The expected behavior is to call to IsEnabled at some point and not log if a call to it should return false

Steps To Reproduce

Implement Microsoft.Extensions.Logging.ILogger
Implement the Log method to only log without checking if should log (relay only on IsEnabled)
Define the system to use the custom logger.
Start a socket connection and reset it while the server accepts it (I didn't find how to do that).the

Exceptions (if any)

No response

.NET Version

6.0, 7.0

Anything else?

Some related PRs and issues:

#31562 (comment)

#31332
dotnet/runtime#51927
dotnet/runtime#50334

[Tratcher]

The IsEnabled check is only an optimization recommended when generating the contents of the log is expensive. The ILogger itself is supposed to check if it's enabled before processing messages. The linked logs don't seem expensive to generate?

[haludi]

The IsEnabled check is only an optimization recommended when generating the contents of the log is expensive. The ILogger itself is supposed to check if it's enabled before processing messages. The linked logs don't seem expensive to generate?

Ok, if this behavior is by design, then the issue can be closed.

This issue has been resolved and has not had any activity for 1 day. It will be closed for housekeeping purposes.

See our Issue Management Policies for more information.