Changing the date / time format reflect to the CurrentCulture all the time

[hishamco]

Background and Motivation

Changing the culture date/time format reflect to the default culture, there's no way in the current APIs to allow the user doesn't rely on the system settings

Proposed API

+ private readonly bool _useUserOverride;
+
    private RequestCulture _defaultRequestCulture =
        new RequestCulture(CultureInfo.CurrentCulture, CultureInfo.CurrentUICulture);

- public RequestLocalizationOptions()
+ public RequestLocalizationOptions() : this(useUserOverride: true)
{
-    RequestCultureProviders = new List<IRequestCultureProvider>
-    {
-        new QueryStringRequestCultureProvider { Options = this },
-        new CookieRequestCultureProvider { Options = this },
-        new AcceptLanguageHeaderRequestCultureProvider { Options = this }
-    };
}

+ public RequestLocalizationOptions(bool useUserOverride)
+{
+    _useUserOverride = useUserOverride;
+    RequestCultureProviders = new List<IRequestCultureProvider>
+    {
+        new QueryStringRequestCultureProvider { Options = this },
+        new CookieRequestCultureProvider { Options = this },
+        new AcceptLanguageHeaderRequestCultureProvider { Options = this }
+    };

Usage Examples

var options = new RequestLocalizationOptions(useUserOverride: true);

app.UseRequestLocalization(options);

Alternative Designs

Risks

[adityamandaleeka]

@hishamco Can you please add a comment with the API proposal to this issue so that it can go through the API review process? More info here: https://github.com/dotnet/aspnetcore/blob/main/docs/APIReviewProcess.md

[hishamco]

I didn't understand what kind of comment should I add? Where?

[BrennanConroy]

See the issue template: https://github.com/dotnet/aspnetcore/issues/new?assignees=&labels=api-suggestion&template=30_api_proposal.md&title=
Either edit the top comment or make a new comment.
See example: #42725

Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:

• The PR contains changes to the reference-assembly that describe the API change. Or, you have included a snippet of reference-assembly-style code that illustrates the API change.
• The PR describes the impact to users, both positive (useful new APIs) and negative (breaking changes).
• Someone is assigned to "champion" this change in the meeting, and they understand the impact and design of the change.

[halter73]

API review notes:

1. Orchard could use this, so it seems useful to add.
2. We want to make this non-breaking
3. Let's make it a settable property like we do for most bool configurable via the options pattern.
4. Are there other things that we might want to configure on the CultureInfo? No.
5. UseUserOverride? CultureInfoUseUserOverride? Something else? Let's go with CultureInfoUseUserOverride because the relationship to CultureInfo isn't as obvious otherwise. Like CultureInfo.UseUserOverride it will default to true.

namespace Microsoft.AspNetCore.Builder;

public class RequestLocalizationOptions
{
+    public bool CultureInfoUseUserOverride { get; set; }
}

API Approved!

[hishamco]

We want to make this non-breaking

There's no breaking-changes here

Let's make it a settable property like we do for most bool configurable via the options pattern.

LGTM

Are there other things that we might want to configure on the CultureInfo?

For now, nope

UseUserOverride? CultureInfoUseUserOverride? Something else? Let's go with CultureInfoUseUserOverride because the relationship to CultureInfo isn't as obvious otherwise

CultureInfoUseUserOverride is weird little bit ;) it's not necessary that we make it obvious, can we use UseUserOverrideCulture or UseSystemCulture?

[halter73]

it's not necessary that we make it obvious

We don't expect this to show up in a lot of code, so clarity trumps terseness. We agree that CultureInfoUseUserOverride quite the mouthful and nongrammatical, but at least if you search "CultureInfoUseUserOverride", you already get some useful documentation.