FindByEmailAsync in the UserOnlyStore is not actually an Async call

[conrad-roux]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

The call made in the UserOnlyStore for the method FindByEmailAsync is not implementing an async method, but the method does in fact have an Async post-fix to the name so I would expect the method to implement an async task.

Expected Behavior

I would expect to see a SingleOrDefaultAsync instead of the used SingleOrDefault similar to what was done in the UserStore with the same method name

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@conrad-roux I am not a member of the .NET team. However, this method as you can tell uses Task.FromResult so the operation still runs in a Task that the consumer can use a GetAwaiter on higher in the call stack.

[springy76]

this method blocks threadpool threads when the IQueryable tries to talk to a busy database server or the connection has problems and it takes 2 seconds to fix the code. What are you waiting for??

[cremor]

I've also noticed this. Seems like it was initially changed to a sync call as a workaround in #10660 by @ajcvickers. A part of the workaround was later removed in #11336 (again by @ajcvickers), but it stayed a sync call. Even later UserStore.FindByEmailAsync was made async again in #24116 (for #24113) by @HaoK, but the UserOnlyStore was not fixed.