LoggerMessage arguments are switched in output

[danielcweber]

Describe the bug

Arguments to a delegate created by LoggerMessage.Define are switched in the output

To Reproduce

Find a minimal repro here. Upon running (and navigating to '/'), it'll output

Health check processing with combined status 123 completed after Healthyms

Notice the switch of "123" and "Healthy". I copied that specific LoggerMessage.Define because it was the HealthCheck output that I first noticed this behaviour in.

I am aware that the specific way that LoggerMessage.Define is written MUST lead to that output, however, this is what I decompiled from Microsoft.Extensions.Diagnostics.HealthChecks and it's the direct consequence of the source-generator-generated code here. So I will recreate the source generation in a further step and post the results here (EDIT: further findings below).

This might be related to #54581 but I can't really tell.

Further technical details

• ASP.NET Core version:
  6.0.0-preview.6.21353.1

• Include the output of dotnet --info

.NET SDK (gemäß "global.json"):
Version:   6.0.100-preview.6.21355.2
Commit:    7f8e0d76c0

Laufzeitumgebung:
OS Name:     Windows
OS Version:  10.0.19043
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\6.0.100-preview.6.21355.2\

Host (useful for support):
 Version: 6.0.0-preview.6.21352.12
 Commit:  770d630b28

.NET SDKs installed:
 3.1.411 [C:\Program Files\dotnet\sdk]
 5.0.101 [C:\Program Files\dotnet\sdk]
 5.0.104 [C:\Program Files\dotnet\sdk]
 5.0.205 [C:\Program Files\dotnet\sdk]
 5.0.301 [C:\Program Files\dotnet\sdk]
 5.0.302 [C:\Program Files\dotnet\sdk]
 6.0.100-preview.6.21355.2 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
 Microsoft.AspNetCore.All 2.1.28 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
 Microsoft.AspNetCore.All 2.2.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
 Microsoft.AspNetCore.App 2.1.28 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
 Microsoft.AspNetCore.App 2.2.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
 Microsoft.AspNetCore.App 3.1.16 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
 Microsoft.AspNetCore.App 3.1.17 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
 Microsoft.AspNetCore.App 5.0.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
 Microsoft.AspNetCore.App 5.0.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
 Microsoft.AspNetCore.App 5.0.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
 Microsoft.AspNetCore.App 6.0.0-preview.6.21355.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
 Microsoft.NETCore.App 2.1.28 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
 Microsoft.NETCore.App 2.2.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
 Microsoft.NETCore.App 3.1.16 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
 Microsoft.NETCore.App 3.1.17 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
 Microsoft.NETCore.App 5.0.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
 Microsoft.NETCore.App 5.0.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
 Microsoft.NETCore.App 5.0.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
 Microsoft.NETCore.App 6.0.0-preview.6.21352.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
 Microsoft.WindowsDesktop.App 3.1.16 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
 Microsoft.WindowsDesktop.App 3.1.17 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
 Microsoft.WindowsDesktop.App 5.0.4 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
 Microsoft.WindowsDesktop.App 5.0.7 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
 Microsoft.WindowsDesktop.App 5.0.8 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
 Microsoft.WindowsDesktop.App 6.0.0-preview.6.21353.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

• The IDE (VS / VS Code/ VS4Mac) you're running on, and its version
  Microsoft Visual Studio Professional 2022 Preview (64-bit)
  Version 17.0.0 Preview 2.1

[danielcweber]

Update: I recreated the source-generation through the use of LoggerMessageAttribute, see here. It doesn't switch arguments anymore. So I guess the HealthCheck-Apis just need a complete recompilation ahead of the next release so the source generator can do its magic.

[danielcweber]

I posted a more general bug report and repro in #34710. Closing this.