AdaptiveCapacityDictionary assert with 11 elements

[Tratcher]

The client sent 11 cookies, the threshold for ACD is 10.

While this is only an assert, I expect being in this invalid state will cause some weird side-effects, potentially discarding cookies when doing incorrect resizes.

Process terminated. Assertion failed.
at Microsoft.AspNetCore.Internal.AdaptiveCapacityDictionary`2.set_Item(TKey key, TValue value) in C:\Github\aspnetcore\src\Shared\Dictionary\AdaptiveCapacityDictionary.cs:line 141
at Microsoft.Net.Http.Headers.CookieHeaderParserShared.TryParseValues(StringValues values, IDictionary`2 store, Boolean enableCookieNameEncoding, Boolean supportsMultipleValues) in C:\Github\aspnetcore\src\Http\Shared\CookieHeaderParserShared.cs:line 37
at Microsoft.AspNetCore.Http.RequestCookieCollection.ParseInternal(StringValues values, Boolean enableCookieNameEncoding) in C:\Github\aspnetcore\src\Http\Http\src\Internal\RequestCookieCollection.cs:line 76
at Microsoft.AspNetCore.Http.RequestCookieCollection.Parse(StringValues values) in C:\Github\aspnetcore\src\Http\Http\src\Internal\RequestCookieCollection.cs:line 65
at Microsoft.AspNetCore.Http.Features.RequestCookiesFeature.get_Cookies() in C:\Github\aspnetcore\src\Http\Http\src\Features\RequestCookiesFeature.cs:line 74
at Microsoft.AspNetCore.Http.DefaultHttpRequest.get_Cookies() in C:\Github\aspnetcore\src\Http\Http\src\Internal\DefaultHttpRequest.cs:line 145
at Microsoft.AspNetCore.Authentication.Cookies.ChunkingCookieManager.GetRequestCookie(HttpContext context, String key) in C:\Github\aspnetcore\src\Shared\ChunkingCookieManager\ChunkingCookieManager.cs:line 101
at Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationHandler.ReadCookieTicket() in C:\Github\aspnetcore\src\Security\Authentication\Cookies\src\CookieAuthenticationHandler.cs:line 143
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine) in System.Private.CoreLib.dll:token 0x6004ea3+0x28
at Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationHandler.ReadCookieTicket() in Microsoft.AspNetCore.Authentication.Cookies.dll:token 0x6000034+0x1f
at Microsoft.AspNetCore.Authentication.Cookies.CookieAuthenticationHandler.EnsureCookieTicket() in C:\Github\aspnetcore\src\Security\Authentication\Cookies\src\CookieAuthenticationHandler.cs:line 78

Stack walk:

_dictionaryStorage and _arrayStorage are not both supposed to have a value

aspnetcore/src/Shared/Dictionary/AdaptiveCapacityDictionary.cs

Lines 579 to 583 in 12c57a5

	[MethodImpl(MethodImplOptions.AggressiveInlining)]
	private int FindIndex(TKey key)
	{
	Debug.Assert(_dictionaryStorage == null);
	Debug.Assert(_arrayStorage != null);

Indexer.Set:

aspnetcore/src/Shared/Dictionary/AdaptiveCapacityDictionary.cs

Line 141 in 12c57a5

var index = FindIndex(key);

aspnetcore/src/Http/Shared/CookieHeaderParserShared.cs

Line 37 in 12c57a5

store[name] = Uri.UnescapeDataString(parsedValue.Value.Value);

Collection created:

aspnetcore/src/Http/Http/src/Internal/RequestCookieCollection.cs

Lines 73 to 76 in 12c57a5

	var collection = new RequestCookieCollection(values.Count);
	var store = collection.Store!;
	if (CookieHeaderParserShared.TryParseValues(values, store, enableCookieNameEncoding, supportsMultipleValues: true))

(related: using StringValues.Count as the initial capacity is actually a bad idea, cookies are supposed to be sent in a single header so there should only be 0 or 1 entries in the StringValues. (except for a Kestrel HTTP/2 #26461 bug which I think is necessary to hit this issue).

Bug: The capacity constructor initializes both fields.

aspnetcore/src/Shared/Dictionary/AdaptiveCapacityDictionary.cs

Lines 79 to 80 in 12c57a5

	_dictionaryStorage = new Dictionary<TKey, TValue>(capacity);
	_arrayStorage = Array.Empty<KeyValuePair<TKey, TValue>>();