-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Closed
Labels
DoneThis issue has been fixedThis issue has been fixedarea-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworkIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Description
A change was made in #20166 that renamed the .version file to Microsoft.AspNetCore.App.versions.txt. It's not clear why this change was made but now there's inconsistency between ASP.NET and the other frameworks. Microsoft.NETCore.App, Microsoft.WindowsDesktop.App and the SDK all have a file named .version.
Repro steps:
- Open https://dotnetcli.blob.core.windows.net/dotnet/Sdk/5.0.100-preview.4.20223.12/dotnet-sdk-5.0.100-preview.4.20223.12-win-x64.zip
- See the following files:
- shared\Microsoft.AspNetCore.App\5.0.0-preview.4.20221.8\Microsoft.AspNetCore.App.versions.txt
- shared\Microsoft.NETCore.App\5.0.0-preview.4.20221.7\.version
- shared\Microsoft.WindowsDesktop.App\5.0.0-preview.4.20222.5\.version
- sdk\5.0.100-preview.4.20223.1\.version
There should be consistent naming amongst all the version files to make it easier for automation that consumes these files. This name change was discovered because it broke the automation at https://github.com/dotnet/dotnet-docker/blob/fe5cedf3f4034a263fa2f118b606233cb708b1b4/eng/get-drop-versions.sh#L20.
Metadata
Metadata
Assignees
Labels
DoneThis issue has been fixedThis issue has been fixedarea-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared frameworkIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework