Skip to content

Commit 2d6d36c

Browse files
committed
Fix browser cookie tests to only run with HTTPS (#39665)
1 parent 68dde4f commit 2d6d36c

File tree

2 files changed

+97
-111
lines changed

2 files changed

+97
-111
lines changed

src/SignalR/clients/ts/FunctionalTests/EchoConnectionHandler.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,13 @@
44
using System.Buffers;
55
using System.Threading.Tasks;
66
using Microsoft.AspNetCore.Connections;
7-
using Microsoft.AspNetCore.Http.Connections;
87

98
namespace FunctionalTests
109
{
1110
public class EchoConnectionHandler : ConnectionHandler
1211
{
1312
public async override Task OnConnectedAsync(ConnectionContext connection)
1413
{
15-
var context = connection.GetHttpContext();
16-
// The 'withCredentials' tests wont send a cookie for cross-site requests
17-
if (!context.WebSockets.IsWebSocketRequest && !context.Request.Cookies.ContainsKey("testCookie"))
18-
{
19-
return;
20-
}
2114

2215
while (true)
2316
{

0 commit comments

Comments
 (0)