-
Couldn't load subscription status.
- Fork 712
[release/9.5] Support parameter names with dashes resolved from underscore configuration #11802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: davidfowl <[email protected]>
… keys Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
…normalization Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
… non-empty values Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
…istinguish configured from generated values Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
…onfiguration Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
…files Co-authored-by: captainsafia <[email protected]>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11802Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11802" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are not very scoped, but they look good and this is important for the deploy scenario. Approved for 9.5.1
Backport of #11785 to release/9.5
/cc @captainsafia @copilot
Customer Impact
Customers cannot set the state of parameters via environment variables in some cases which make it hard to use in a CI pipeline.
Testing
Manual and Automatic.
Risk
Low.
Regression?
No